CAMEL-23276: Add PluginRunCustomizer to JBang Plugin SPI#22473
Open
Croway wants to merge 2 commits intoapache:mainfrom
Open
CAMEL-23276: Add PluginRunCustomizer to JBang Plugin SPI#22473Croway wants to merge 2 commits intoapache:mainfrom
Croway wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Move PluginRunCustomizer.beforeRun() to run before PluginExporter.getDependencies() so plugins can set up config directories before dependency scanning occurs.
6 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
PluginRunCustomizerinterface withbeforeRun(KameletMain, List<String>)hookPlugin.getRunCustomizer()default method (followsgetExporter()pattern)Run.run()invokes active plugin customizers after dependency resolution but beforeKameletMain.start()--skip-pluginsflagThis allows third-party plugins to customize the environment (system properties, config directories, initial properties) based on file arguments, without needing to subclass the Run command.
Test plan
PluginRunCustomizerTest: verifies default returns empty, verifies customizer receives correct argumentsClaude Code on behalf of Federico Mariani