-
Notifications
You must be signed in to change notification settings - Fork 115
[runtime] Support per-event-type configurable log levels for event log #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
weiqingy
wants to merge
8
commits into
apache:main
Choose a base branch
from
weiqingy:541-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9b8c335
[runtime] Add EventLogLevel enum, config options, and remove EventFilter
weiqingy 1f17c54
[runtime] Add EventLogLevelResolver and JsonTruncator with unit tests
weiqingy 239eefb
[runtime] Integrate log levels into FileEventLogger, serializer, and …
weiqingy fd7bd37
[python] Add event log level config options and E2E tests
weiqingy 96e8d65
[runtime] Fix PythonEvent type resolution and remove dead code
weiqingy c3bbc3e
Retrigger CI
weiqingy 48ed7db
Retrigger CI
weiqingy 2f9eb23
[runtime] Address review feedback on event log level feature
weiqingy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
61 changes: 0 additions & 61 deletions
61
api/src/main/java/org/apache/flink/agents/api/EventFilter.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
api/src/main/java/org/apache/flink/agents/api/logger/EventLogLevel.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.agents.api.logger; | ||
|
|
||
| /** | ||
| * Log level for event logging, controlling the verbosity of event log output. | ||
| * | ||
| * <ul> | ||
| * <li>{@link #OFF} - No events of this type are logged. | ||
| * <li>{@link #STANDARD} - Events are logged with truncated/summarized payloads (default). | ||
| * <li>{@link #VERBOSE} - Events are logged with full, untruncated payloads. | ||
| * </ul> | ||
| */ | ||
| public enum EventLogLevel { | ||
|
|
||
| /** No events of this type are logged. */ | ||
| OFF, | ||
|
|
||
| /** Events are logged with truncated/summarized payloads. This is the default level. */ | ||
| STANDARD, | ||
|
|
||
| /** Events are logged with full, untruncated payloads. */ | ||
| VERBOSE; | ||
|
|
||
| /** | ||
| * Parses a string value into an {@link EventLogLevel}, case-insensitively. | ||
| * | ||
| * @param value the string representation of the log level (e.g., "off", "STANDARD", "Verbose") | ||
| * @return the corresponding {@link EventLogLevel} | ||
| * @throws IllegalArgumentException if the value does not match any log level | ||
| */ | ||
| public static EventLogLevel fromString(String value) { | ||
| if (value == null) { | ||
| throw new IllegalArgumentException("EventLogLevel value cannot be null"); | ||
| } | ||
| try { | ||
| return valueOf(value.toUpperCase()); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new IllegalArgumentException( | ||
| "Invalid EventLogLevel: '" | ||
| + value | ||
| + "'. Valid values are: OFF, STANDARD, VERBOSE"); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just use enum here
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the PR.