[feature] Enable EventLog display in WebUI by default#638
Open
GreatEugenius wants to merge 2 commits intoapache:mainfrom
Open
[feature] Enable EventLog display in WebUI by default#638GreatEugenius wants to merge 2 commits intoapache:mainfrom
GreatEugenius wants to merge 2 commits intoapache:mainfrom
Conversation
github-actions
Bot
added
doc-included
Collaborator
Author
|
Hi, @Sxnan and @wenjin272 . Could you please review this PR? Thank you! |
Collaborator
|
Hi, @GreatEugenius. Overall looks good to me, I left some minor comments about details. Additionally, after #609 is merged, I think you may need to make further adjustments. |
Collaborator
Author
Understood, I will rebase to the main branch after #609 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #252
Purpose of change
Enable EventLog display in WebUI by default.
Tests
UT and local end-to-end testing in the Flink Standalone Cluster:
API
No
Documentation
doc-neededdoc-not-neededdoc-included