[FLINK-39373][pipeline][starrocks] Fix the error when modifying the default value of a column#4363
Open
linguoxuan wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39373][pipeline][starrocks] Fix the error when modifying the default value of a column#4363linguoxuan wants to merge 1 commit intoapache:masterfrom
linguoxuan wants to merge 1 commit intoapache:masterfrom
Conversation
…efault value of a column
Contributor
Author
|
@lvyanquan @rmetzger PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a bug in the StarRocks pipeline sink where executing AlterColumnTypeEvent would cause the existing default value of a column to be lost.
Bug
When AlterColumnTypeEvent is applied to modify a column's data type in StarRocks, the event does not carry the column's original default value. As a result, the generated ALTER TABLE ... MODIFY COLUMN SQL statement omits the DEFAULT clause, causing StarRocks to throw an error.
Changes
Added getColumnDefaultValue() method in StarRocksEnrichedCatalog to query the current default value of a column from information_schema.COLUMNS.
Added getConnection() helper method to obtain a JDBC connection from the parent StarRocksCatalog via reflection.
Modified alterColumnType() to check and preserve the existing default value when the new column definition does not specify one.
Added integration test testAlterColumnTypePreservesDefaultValue to verify that the default value is retained after altering the column type.