[FLINK-39403][cdc-connector] Fix transaction leak during snapshot split read for DB2, Oracle, PostgreSQL, and SQL Server connectors#4364
Open
linguoxuan wants to merge 1 commit intoapache:masterfrom
Conversation
…r DB2, Oracle, PostgreSQL, and SQL Server connectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
During the snapshot split reading phase,
initStatement()setsautoCommittofalseon the JDBCconnection to enable cursor-based result set fetching. However, after the split read completes, the transaction is never committed and
autoCommitis never restored totrue. This may lead to idle transactions leak.Change
Added a
finallyblock increateDataEventsForTable()ofDb2ScanFetchTask,OracleScanFetchTask,PostgresScanFetchTask, andSqlServerScanFetchTaskto restoreautoCommittotrueafter each snapshot split read.