Skip to content

[VL] Remove support for BNLJ full outer join without condition#11021

Merged
zml1206 merged 3 commits into
apache:mainfrom
zml1206:remove_support_blnj_full
Nov 5, 2025
Merged

[VL] Remove support for BNLJ full outer join without condition#11021
zml1206 merged 3 commits into
apache:mainfrom
zml1206:remove_support_blnj_full

Conversation

@zml1206

@zml1206 zml1206 commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

As this discussion, #8965 (comment), we will remove this support.
Also fix #10989

How was this patch tested?

@github-actions github-actions Bot added CORE works for Gluten Core VELOX labels Nov 4, 2025
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@jinchengchenghh jinchengchenghh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@zml1206

zml1206 commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @jinchengchenghh . Merge into main.

@zml1206 zml1206 merged commit 21c0e43 into apache:main Nov 5, 2025
101 of 102 checks passed
@zhouyuan

zhouyuan commented Nov 7, 2025

Copy link
Copy Markdown
Member

It looks like we should also backport to 1.5
Cc @philo-he

@philo-he

Copy link
Copy Markdown
Member

It looks like we should also backport to 1.5 Cc @philo-he

@zhouyuan, +1. I just created a GitHub issue for tracking those patches for backporting: #11058, with this patch added to the tracking list.

@zml1206

zml1206 commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

Backport in #11060 @zhouyuan @philo-he

philo-he pushed a commit that referenced this pull request Nov 14, 2025
@zml1206 zml1206 deleted the remove_support_blnj_full branch December 9, 2025 08:11
zml1206 added a commit to zml1206/gluten that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[VL] Full outer join without join condition in BroadcastNestedLoopJoinExecTransformer failed

4 participants