Skip to content

[CORE] Avoid getting duplicate resource files for component discovery #11043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philo-he merged 2 commits into from
Nov 10, 2025
Merged

[CORE] Avoid getting duplicate resource files for component discovery #11043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99b8863
Initial
philo-he Nov 7, 2025
06e88c7
Fix typo
philo-he Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gluten-core/src/main/java/org/apache/gluten/utils/ResourceUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public static List<String> getResources(final String container, final Pattern pa
final List<String> buffer = new ArrayList<>();
final Enumeration<URL> containerUrls;
try {
containerUrls = Thread.currentThread().getContextClassLoader().getResources(container);
containerUrls = ResourceUtil.class.getClassLoader().getResources(container);

@zhztheplayer zhztheplayer Nov 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The change itself looks reasonable, and I didn't realize context class loader could result in duplicated resources. Will find some time to debug on my end.

} catch (IOException e) {
throw new GlutenException(e);
}
Expand Down
2 changes: 1 addition & 1 deletion gluten-core/src/main/scala/org/apache/gluten/component/Discovery.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private object Discovery extends Logging {
val out = allFiles.flatMap {
case componentFilePattern(className) =>
if (!deDup.add(className)) {
logWarning(s"Found duplicated component class $className in then classpath, ignoring.")
logWarning(s"Found duplicated component class $className in the classpath, ignoring.")
None
} else {
val clazz =
Expand Down