Skip to content

[CH] Improve SparkFloorFunction performance with SVE#11045

Closed
chiranmoyf wants to merge 1 commit into
apache:mainfrom
chiranmoyf:SVE-Implementation-for-Spark-floor-function
Closed

[CH] Improve SparkFloorFunction performance with SVE#11045
chiranmoyf wants to merge 1 commit into
apache:mainfrom
chiranmoyf:SVE-Implementation-for-Spark-floor-function

Conversation

@chiranmoyf

Copy link
Copy Markdown

What changes are proposed in this pull request?

This commit introduces support for the Scalable Vector Extension (SVE) in SparkFloorFunction.

How was this patch tested?

We've used Google's microbenchmark BM_SparkFloorFunction_For_Float64 to test the patch. The results are presented below.

./build_gcc/utils/extern-local-engine/tests/benchmark_local_engine --benchmark_filter="BM.*SparkFloor.*Float64"               

# Before optimization (Scalar)
----------------------------------------------------------------------------
Benchmark                                  Time             CPU   Iterations
----------------------------------------------------------------------------
BM_SparkFloorFunction_For_Float64     79407 ns       79407 ns         8768

# After optimization (SVE)
----------------------------------------------------------------------------
Benchmark                                  Time             CPU   Iterations
----------------------------------------------------------------------------
BM_SparkFloorFunction_For_Float64     40479 ns       40479 ns         17291

We are getting around 2x performance improvement on AWS Graviton3 (m7g.4xlarge).

Note

SVE detection and macros used here are enabled in Clickhouse. We are raising this PR as draft since the Clickhouse PR is under review. Here in the Clickhouse PR for reference - ClickHouse/ClickHouse#85010

@github-actions

github-actions Bot commented Nov 7, 2025

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

1 similar comment
@taiyang-li

Copy link
Copy Markdown
Contributor

Run Gluten Clickhouse CI on x86

@taiyang-li

Copy link
Copy Markdown
Contributor
image It seems related to the changes. cc @chiranmoyf

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the stale stale label Dec 24, 2025
@chiranmoyf

Copy link
Copy Markdown
Author

The build error occurs because the macros are undefined in ClickHouse. We are working on the ClickHouse PR. Once it is merged, the issue should be resolved.

@github-actions github-actions Bot removed the stale stale label Jan 3, 2026
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the stale stale label Feb 17, 2026
@github-actions

Copy link
Copy Markdown

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions Bot closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants