[VL] Make VeloxResizeBatchesExec not inherit ColumnarToColumnarTransition#11072
Merged
Conversation
…tion It's an improvement following apache#10763. The PR decouples ColumnarToColumnarExec from ColumnarToColumnarTransition to make them both can be solely implemented. If a class inherits from ColumnarToColumnarExec but not from ColumnarToColumnarTransition at the same time, it will not be considered as a transition, so it's not going to be removed by RemoveTransitions rule.
Member
Author
|
Run Gluten Clickhouse CI on x86 |
jinchengchenghh
approved these changes
Nov 13, 2025
Member
Author
|
Thanks @Zouxxyy @jinchengchenghh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR's an improvement following #10763.
It decouples
ColumnarToColumnarExecfromColumnarToColumnarTransitionto make them both can be solely implemented. If a class inherits fromColumnarToColumnarExecbut not fromColumnarToColumnarTransitionat the same time, it will not be considered as a transition, so it's not going to be removed by RemoveTransitions rule.After the refactor,
VeloxResizeBatchesExecwill not inheritColumnarToColumnarTransitionand it will have nothing to do with the transition planner. So developers don't have to consider the transition logic when working with it or other similar unary columnar operators.