Skip to content

[MINOR][VL] Re-enable stale ignored atan2 test in MathFunctionsValidateSuite #12199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philo-he merged 1 commit into from
Jun 8, 2026
+5 −3
Merged

[MINOR][VL] Re-enable stale ignored atan2 test in MathFunctionsValidateSuite #12199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class MathFunctionsValidateSuiteAnsiOn extends FunctionsValidateSuite {
}
}

abstract class MathFunctionsValidateSuite extends FunctionsValidateSuite {
class MathFunctionsValidateSuite extends FunctionsValidateSuite {

disableFallbackCheck
import testImplicits._
Expand Down Expand Up @@ -96,7 +96,7 @@ abstract class MathFunctionsValidateSuite extends FunctionsValidateSuite {
}
}

ignore("atan2") {
test("atan2") {
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
checkGlutenPlan[ProjectExecTransformer]
}
Expand Down Expand Up @@ -414,7 +414,9 @@ abstract class MathFunctionsValidateSuite extends FunctionsValidateSuite {
}
}

test("decimal arithmetic respects allowPrecisionLoss captured at view analysis time") {
testWithMinSparkVersion(
"decimal arithmetic respects allowPrecisionLoss captured at view analysis time",
"4.1") {
// Regression test for GLUTEN-11917: in Spark 4.1, arithmetic expressions embed
// allowPrecisionLoss in their evalContext at analysis time. Gluten must read from
// the expression rather than SQLConf.get, which can differ when querying a view
Expand Down
Loading