fix(gh-copilot): throwing on parsing for a 204 response#8825
Open
ReeceXW wants to merge 2 commits intoapache:mainfrom
Open
fix(gh-copilot): throwing on parsing for a 204 response#8825ReeceXW wants to merge 2 commits intoapache:mainfrom
ReeceXW wants to merge 2 commits intoapache:mainfrom
Conversation
dosubot
bot
added
the
size:S
dosubot
bot
added
component/plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's possible the user metrics endpoint can return a 204 No Content, but we are only ignoring a 404. This leads to trying to parse a response that isn't valid and collection stops.
I've added the exclusion and some more logging