Add mqtt IT for json mode.#17090
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a single line to set the MQTT client ID in the integration test setup. However, there is a significant discrepancy between the PR description and the actual implementation.
Changes:
- Sets a hardcoded client ID ("clientId01") for the MQTT connection in the test setup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mqtt.setPassword(PASSWORD); | ||
| mqtt.setConnectAttemptsMax(3); | ||
| mqtt.setReconnectDelay(10); | ||
| mqtt.setClientId("clientId01"); |
There was a problem hiding this comment.
This PR claims to "Add mqtt IT for json mode" but the test is configured to use the "line" payload formatter (FORMATTER = "line" on line 56), not JSON. The line formatter processes line protocol format data, while the json formatter would process JSON format data. Either the PR description is incorrect, or the test should be using FORMATTER = "json" to test JSON mode as described.
wenyanshi-123
force-pushed
the
addMqttIT
branch
from
745d9c2 to
ed6357c
Compare
wenyanshi-123
force-pushed
the
addMqttIT
branch
from
ed6357c to
4945f1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mqtt IT for json mode.