Fix allValueColDeletedMap index out of bound caused by stale rowCount after TVList sort#17098
Merged
Merged
Conversation
… after TVList sort
JackieTien97
approved these changes
Jan 28, 2026
jt2594838
approved these changes
Jan 28, 2026
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17098 +/- ##
============================================
+ Coverage 39.18% 39.19% +0.01%
Complexity 282 282
============================================
Files 5128 5128
Lines 343172 343169 -3
Branches 43764 43762 -2
============================================
+ Hits 134459 134495 +36
+ Misses 208713 208674 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shuwenwei
added a commit
that referenced
this pull request
Jan 28, 2026
… after TVList sort (#17098)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
When writes occur between the prepare phase and actual query execution, TVList sorting may include newly written rows and increase the row count.If the query continues to use the stale queryRowCount captured during prepare, bitmap construction may access out-of-bounds indices. This change refreshes the rowCount after sorting and ensures bitmap operations use the updated value.