[DOC] Remove unsupported 'logo_only' and 'extra_navbar' theme options#7211
Closed
dnskr wants to merge 1 commit into
Closed
[DOC] Remove unsupported 'logo_only' and 'extra_navbar' theme options#7211dnskr wants to merge 1 commit into
dnskr wants to merge 1 commit into
Conversation
Signed-off-by: dnskr <dnskrv88@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7211 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 696 696
Lines 43540 43540
Branches 5891 5891
======================================
Misses 43540 43540 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pan3793
approved these changes
Sep 22, 2025
pan3793
pushed a commit
that referenced
this pull request
Sep 22, 2025
…' theme options ### Why are the changes needed? The PR fixes two `unsupported theme option` warnings that are printed during the documentation building: ```shell preparing documents... WARNING: unsupported theme option 'logo_only' given WARNING: unsupported theme option 'extra_navbar' given ``` Both options were deleted from [sphinx_book_theme](https://github.com/executablebooks/sphinx-book-theme). ### How was this patch tested? Built documentation locally and checked there are no warning message anymore. ### Was this patch authored or co-authored using generative AI tooling? No Closes #7211 from dnskr/remove-unsupported-theme-options. Closes #7211 800f9d9 [dnskr] [DOC] Remove unsupported 'logo_only' and 'extra_navbar' theme options Authored-by: dnskr <dnskrv88@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit d5468d0) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
|
thanks, merged to master/1.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The PR fixes two
unsupported theme optionwarnings that are printed during the documentation building:Both options were deleted from sphinx_book_theme.
How was this patch tested?
Built documentation locally and checked there are no warning message anymore.
Was this patch authored or co-authored using generative AI tooling?
No