[KYUUBI #XXXX] Do not block server shutdown on batch sessions#7498
Closed
turboFei wants to merge 2 commits into
Closed
[KYUUBI #XXXX] Do not block server shutdown on batch sessions#7498turboFei wants to merge 2 commits into
turboFei wants to merge 2 commits into
Conversation
Batch sessions are handles to jobs submitted to external clusters (YARN/K8s). The actual computation runs on the cluster and continues regardless of Kyuubi server state. Including batch sessions in the shutdown wait loop caused the server to hang indefinitely when long- running batch jobs were active. Introduces `closeOnServerStop` on the Session trait (default: true, backward-compatible). KyuubiBatchSession overrides it to false. ServiceDiscovery.stopGracefully now waits only for sessions where closeOnServerStop is true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ServiceDiscovery.stopGracefullywaits forgetActiveUserSessionCount > 0to reach zero before shutting down. This count includes batch sessions, which are just handles to jobs running on external clusters (YARN/K8s). Those jobs can run for hours or days — causing the server to hang indefinitely on shutdown.What
Introduces a
closeOnServerStopflag on theSessiontrait (defaulttrue— fully backward-compatible with all existing session types).KyuubiBatchSessionoverrides it tofalse.ServiceDiscovery.stopGracefullynow waits only for sessions wherecloseOnServerStop = true, so batch sessions no longer block server shutdown.Changes
Sessiontrait: addcloseOnServerStop: Boolean = trueKyuubiBatchSession: override tofalseServiceDiscovery.stopGracefully: switch fromgetActiveUserSessionCounttoallSessions().count(_.closeOnServerStop)Test plan