perf: cache derived AWS V4 and OSS V4 keys#766
Open
akx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to cache part of the HMAC computations for Amazon AWS V4 and the similarly-built Aliyun OSS V4 keys.
On my machine, this seems to benchmark a 20% improvement in speed in the common case of using the same RequestSigner with the same Credentials for sequential signings.
Note
The
secretnaturally does need to be part of the cache key. This means a Credentials' secret, once used with a RequestSigner, will be in process memory until another secret is used with the same request signer instance.That said, I don't think that's a huge issue at present, since there is seemingly no guarantee of memory cleaning when dropping a
Credentialsobject either.