[core] Unify single-column global index writer#8275
Merged
JingsongLi merged 3 commits intoJun 18, 2026
Merged
Conversation
3d2839a to
fd0e495
Compare
leaves12138
approved these changes
Jun 18, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update. I re-reviewed the latest revision and the single-column writer API now looks consistent across BTree, vector, Lumina, Tantivy, Flink and Spark build paths.
The important semantic change is also correct: vector/full-text writers now persist the caller-provided relative row id instead of relying on an implicit dense sequence, while rowCount still represents logical rows processed for index metadata. This matches sparse/sharded row ranges and the added multiple-index-file tests cover the regression case.
I also ran the focused checks locally:
mvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -Dtest='VectorSearchBuilderTest#testVectorSearchWithMultipleIndexFiles,FullTextSearchBuilderTest#testFullTextSearchWithMultipleIndexFiles' testmvn -pl paimon-lumina -am -Pfast-build -DfailIfNoTests=false -Dtest='LuminaVectorGlobalIndexWriterTest' test
Both passed. +1 from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR merges the previous singleton and parallel single-column global index writer APIs into one
GlobalIndexSingleColumnWriterinterface. Single-column index writers now receive the caller-provided shard-relative row id throughwrite(@Nullable Object key, long relativeRowId).Changes
GlobalIndexSingletonWriterandGlobalIndexParallelWriterwithGlobalIndexSingleColumnWriter.Testing
mvn -pl paimon-vector/paimon-vector-index -am -Pfast-build -DskipTests test-compilemvn -pl paimon-lumina -am -Pfast-build -DskipTests test-compilemvn -pl paimon-tantivy/paimon-tantivy-index -am -Pfast-build -DskipTests test-compilemvn -pl paimon-flink/paimon-flink-common -am -Pfast-build -DskipTests test-compilemvn -pl paimon-spark/paimon-spark-common -am -Pfast-build -DskipTests compilegit diff --check