RFC: Add format_major_version and format_minor_version to thrift metadata#582
Draft
alamb wants to merge 3 commits into
Draft
RFC: Add format_major_version and format_minor_version to thrift metadata#582alamb wants to merge 3 commits into
format_major_version and format_minor_version to thrift metadata#582alamb wants to merge 3 commits into
Conversation
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
NOTE: there is an alternate RFC here
minor_versionin thrift metadata #581As described on the mailing list thread about versions, there is currently no way for a parquet reader to know which if the many parquet features it may encounter in a particular file
The current
versionfield in the thirft metadata is insufficient because:2. There is no agreed upon definition of
versionand many writers use it incorrectly:parquet-format/src/main/thrift/parquet.thrift
Lines 1368 to 1373 in 74001e4
versionfield, version "2" has several forward incompatible changes (see Document Parquet Features by Version parquet-site#186) meaning a reader doesn't know what features it may encounterWhat changes are included in this PR?
Add net new
format_major_versionandformat_minor_versionfields to the thrift metadata to encode the version of parquet-format. Readers can use this field to determine what features it may encounter.Open questions:
versionto 2 and then use major/minor version?)versionfield?These field would be ignored by older readers
Do these changes have PoC implementations?
Not yet