fix(python/sedonadb): serialize pyogrio reader lifecycles - #1187
Draft
jiayuasu wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ExternalFormatSpeccapability for formats that cannot safely consume multiple file readers concurrentlyWhy
#1051 serialized pyogrio context entry and exit, but active Arrow streams could still overlap. Subsequent wheel runs continued to abort during multi-file and partitioned pyogrio reads, as tracked in #1072.
An unchanged CPython 3.12 comparison repeatedly ran the two affected tests in fresh processes and reproduced SIGABRT at iteration 72 during
test_read_ogr_partitioned: run 32625781579.This change keeps one scan-local permit from reader creation through consumption and native cleanup. Pyogrio multi-file scans therefore trade file-level parallelism for stability. Other external formats retain concurrent reads by default, and independent physical scans do not share a process-wide lock.
Verification
cargo fmt --all -- --checkcargo test -p sedona-datasource -p sedonadb --lib(9 + 11 tests passed)cargo clippy -p sedona-datasource -p sedonadb --lib --no-deps -- -D warningsCloses #1072.
Follow-up to #924 and #1051. Replacing the Python reader with the native GDAL reader remains tracked in #1092.