Skip to content

Dependabot/gorilla/websocket#1420

Open
gygdh-001 wants to merge 3 commits into
apache:masterfrom
gygdh-001:dependabot/gorilla/websocket
Open

Dependabot/gorilla/websocket#1420
gygdh-001 wants to merge 3 commits into
apache:masterfrom
gygdh-001:dependabot/gorilla/websocket

Conversation

@gygdh-001

@gygdh-001 gygdh-001 commented Jul 11, 2023

Copy link
Copy Markdown

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
  • Never comment source code, delete it.
  • UT should has "context, subject, expected result" result as test case name, when you call t.Run().

@gygdh-001

Copy link
Copy Markdown
Author

OK

1 similar comment
@gygdh-001

Copy link
Copy Markdown
Author

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants