Conversation
uros-b
left a comment
There was a problem hiding this comment.
PTAL @HyukjinKwon @srowen
|
soft ping here ^^ |
|
Hi, @uros-b . Please be careful in GitHub. Your PR is giving lots of noise to someone who has the valid GitHub Account name like the following. 😄
|
|
The doc changes look correct to me: all four Could you retitle the PR before merge, e.g. Nit: the 2nd and 4th |
@return tags to the public StateSpec methods
@return tags to the public StateSpec methods|
My apologies to the innocent GitHub user who I tagged here! That's a super cool username, but I couldn't imagine the inbox...😭 |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for addressing the comments, @uros-b . The added @tparam KeyType tags look good, and the title no longer contains @.
nit: it would be great to mention the @tparam KeyType additions in the PR description too, since it becomes the commit message.
### What changes were proposed in this pull request? This completes the Scaladoc on the public `StateSpec` API: - Adds `return` tags to all nine public methods that lacked them: - the four `StateSpec.function(...)` factory overloads (companion object) -- "a new `StateSpec` for the `mapWithState` operation"; - the five builder methods on the abstract class (`initialState` x2, `numPartitions`, `partitioner`, `timeout`), which return `this.type` -- "this `StateSpec` (to allow chaining)". - Adds the missing `tparam KeyType` to the second and fourth `StateSpec.function(...)` overloads, which previously documented only `ValueType` / `StateType` / `MappedType`. Scaladoc only; no code changes. ### Why are the changes needed? It completes the Scaladoc for the public `StateSpec` surface so the generated API docs state what each method returns and document every type parameter. The `function` factories return a freshly built `StateSpec`, and the builder methods return the same instance to allow fluent chaining (as in the class example, `StateSpec.function(mappingFunction).numPartitions(10)`); this closes a small, pre-existing doc gap. ### Does this PR introduce _any_ user-facing change? No. Scaladoc-only; no API or behavior change. ### How was this patch tested? N/A -- documentation-only change. The `streaming` module compiles cleanly. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #58563 from uros-b/apidoc-statespec-return. Authored-by: Uros <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit 2dcbadb) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
|
Thank you @dongjoon-hyun! |


What changes were proposed in this pull request?
This completes the Scaladoc on the public
StateSpecAPI:@returntags to all nine public methods that lacked them:StateSpec.function(...)factory overloads (companion object) -- "a newStateSpecfor themapWithStateoperation";initialStatex2,numPartitions,partitioner,timeout), which returnthis.type-- "thisStateSpec(to allow chaining)".@tparam KeyTypeto the second and fourthStateSpec.function(...)overloads, which previously documented onlyValueType/StateType/MappedType.Scaladoc only; no code changes.
Why are the changes needed?
It completes the Scaladoc for the public
StateSpecsurface so the generated API docs state what each method returns and document every type parameter. Thefunctionfactories return a freshly builtStateSpec, and the builder methods return the same instance to allow fluent chaining (as in the class example,StateSpec.function(mappingFunction).numPartitions(10)); this closes a small, pre-existing doc gap.Does this PR introduce any user-facing change?
No. Scaladoc-only; no API or behavior change.
How was this patch tested?
N/A -- documentation-only change. The
streamingmodule compiles cleanly.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)