[SPARK-59093][PS][TEST][FOLLOWUP] Skip floor division overflow tests on old NumPy - #58732
Open
Spenserrrr wants to merge 1 commit into
Open
[SPARK-59093][PS][TEST][FOLLOWUP] Skip floor division overflow tests on old NumPy#58732Spenserrrr wants to merge 1 commit into
Spenserrrr wants to merge 1 commit into
Conversation
Spenserrrr
marked this pull request as ready for review
September 11, 2026 05:16
Contributor
Author
|
Hi @zhengruifeng @gaogaotiantian! This PR fixes the minimum-dependency CI failure by skipping the integer floor division overflow tests on NumPy < 1.24. Could you take a look when you have time? Thanks! |
gaogaotiantian
approved these changes
Sep 11, 2026
uros-b
approved these changes
Sep 11, 2026
Member
|
Thank you @Spenserrrr and @gaogaotiantian! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move integer floor-division overflow cases into dedicated tests and skip them with NumPy below 1.24. Keep the other floor-division cases running, including the non-overflowing minimum-int64 case.
Why are the changes needed?
Minimum-dependency CI fails because pandas with NumPy 1.23.2 returns zero for
pd.Series([-(2**63)]) // -1, while pandas-on-Spark returns minimum int64. NumPy documents this overflow result as undefined before 1.24.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran the Classic and Connect floor-division tests with minimum and current dependencies, and an overflow probe reproducing the original comparison failures.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-6)