[SPARK-59443][SQL] Reduce allocations in ArrowColumnVector decimal reads - #58748
Open
xiaoh1024 wants to merge 1 commit into
Open
[SPARK-59443][SQL] Reduce allocations in ArrowColumnVector decimal reads#58748xiaoh1024 wants to merge 1 commit into
xiaoh1024 wants to merge 1 commit into
Conversation
Read native Decimal128 words for source precision 1-18 while preserving full-width fallback and Spark decimal conversion semantics. Add decimal regression coverage and a read benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a small-decimal accessor for Arrow columns with source precision 1-18,
with full-width fallback and existing Spark decimal conversion semantics.
Add regression tests and an Arrow decimal read benchmark.
Why are the changes needed?
See SPARK-59443.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
build/sbt catalyst/compile sql/Test/compilebuild/sbt "sql/testOnly org.apache.spark.sql.vectorized.ArrowColumnVectorSuite"(28 tests passed, including 8 new decimal tests).
under QEMU, including a native Arrow Decimal128 layout check.
original accessor.
passed with JDK 17 and Scala 2.13.
Was this patch authored or co-authored using generative AI tooling?
AI assistance was used for implementation, tests, and local validation.
Generated-by: Codex CLI 0.154.0