[SPARK-59460][SQL] Assign a name to the error condition _LEGACY_ERROR_TEMP_1072 - #58759
Open
Ma77Ball wants to merge 1 commit into
Open
[SPARK-59460][SQL] Assign a name to the error condition _LEGACY_ERROR_TEMP_1072#58759Ma77Ball wants to merge 1 commit into
Ma77Ball wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename the legacy error condition
_LEGACY_ERROR_TEMP_1072toTABLES_OR_VIEWS_NOT_IN_SAME_DATABASE(SQLSTATE0A000). It is raised bySessionCatalog.getTablesByNamewhen the requested tables/views span more than one database. The message is also reworded for clarity.Why are the changes needed?
The error-conditions README disallows new
_LEGACY_ERROR_TEMP_*entries and asks existing ones to be resolved. This resolves one (part of SPARK-37935).Does this PR introduce any user-facing change?
Yes. The condition becomes
TABLES_OR_VIEWS_NOT_IN_SAME_DATABASE, and the message is reworded to "Cannot retrieve tables or views that do not belong to the same database. Requested: ."How was this patch tested?
Strengthened the existing
SessionCatalogSuitetest to assert the condition and parameters viacheckError(it previously only intercepted the exception).SparkThrowableSuitepasses.Was this patch authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8