[WIP][TEZ-3904] An API to update tokens for Tez AM and the DAG#22
Open
beltran wants to merge 1 commit intoapache:masterfrom
Open
[WIP][TEZ-3904] An API to update tokens for Tez AM and the DAG#22beltran wants to merge 1 commit intoapache:masterfrom
beltran wants to merge 1 commit intoapache:masterfrom
Conversation
beltran
commented
Jun 14, 2018
| String pid, ExecutionContext ExecutionContext, long memAvailable, | ||
| boolean updateSysCounters, HadoopShim hadoopShim, | ||
| TezExecutors sharedExecutor) throws IOException { | ||
| TezExecutors sharedExecutor, SystemEventHandler systemEventHandler) throws IOException { |
Contributor
Author
There was a problem hiding this comment.
This API changes, this is bad?
beltran
commented
Jun 14, 2018
| ExecutionContext executionContext, long memAvailable, | ||
| boolean updateSysCounters, HadoopShim hadoopShim, | ||
| TezExecutors sharedExecutor) throws | ||
| TezExecutors sharedExecutor, SystemEventHandler systemEventHandler) throws |
beltran
commented
Jun 14, 2018
|
|
||
| @Private | ||
| @VisibleForTesting | ||
| public static Credentials createAMCredentials(ApplicationId appId, |
Contributor
Author
There was a problem hiding this comment.
I pulled this out because I was going to reuse but will leave it back in if I don't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has ended up bigger than what I expected so I wanted to ask for some feedback before going forward. This is what is does mainly:
updateAMCredentialsandupdateDAGCredentialstoTezClient. This is not the final API but this functions will be useful anyway to send the credentialsSystemEventHandlerin the runtime internals to process theUpdateCredentialsEventsUpdateCredentialsEventevent and some transitions to theTaskImpl's state machine that represent the credentials being updated.TODO: