style(symfony): fix cs-fixer + phpstan on upgrade-filter

php-cs-fixer: global \is_callable, phpdoc @throws/@return order.
phpstan: ?-> on getMethod() flagged never-null by parser stub ->
explicit constructor guard (also runtime-safe; getMethod can be null).

Author: soyuka

src/Symfony/Bundle/Command/Upgrade/UpgradeApiFilterMapper.php

@@ -36,7 +36,7 @@ public function map(string $filterClass, ?string $strategy = null, ?string $prop
         }
 
         $shortName = substr($filterClass, \strlen($namespace) + 1);
-        $canonical = fn (string $name): string => $namespace.'\\'.$name;
+        $canonical = static fn (string $name): string => $namespace.'\\'.$name;
 
         return match ($shortName) {
             'BooleanFilter' => new UpgradeApiFilterMapping($canonical('ExactFilter'), castToNativeType: true, nativeType: 'bool'),

src/Symfony/Bundle/Command/Upgrade/UpgradeApiFilterParameter.php

@@ -21,16 +21,16 @@
 final readonly class UpgradeApiFilterParameter
 {
     /**
-     * @param string      $key              the parameter key (query string name)
-     * @param string      $filterClass      canonical replacement filter FQCN to instantiate
-     * @param string|null $property         explicit property when it differs from $key
-     * @param string|null $nativeType       scalar native type hint (bool|int|float|string), null to omit
-     * @param bool        $castToNativeType whether the QueryParameter should coerce the raw value
-     * @param string|null $filterContext    filter-specific config carried by the QueryParameter (e.g. the
-     *                                       DateFilter null-management mode), null to omit
-     * @param bool                 $caseSensitive emit `caseSensitive: true` on the search filter (case-sensitive
-     *                                            strategy); the new search filters are case-insensitive by default
-     * @param array<string, mixed> $arguments     constructor arguments to pass to the (kept) filter, named
+     * @param string               $key              the parameter key (query string name)
+     * @param string               $filterClass      canonical replacement filter FQCN to instantiate
+     * @param string|null          $property         explicit property when it differs from $key
+     * @param string|null          $nativeType       scalar native type hint (bool|int|float|string), null to omit
+     * @param bool                 $castToNativeType whether the QueryParameter should coerce the raw value
+     * @param string|null          $filterContext    filter-specific config carried by the QueryParameter (e.g. the
+     *                                               DateFilter null-management mode), null to omit
+     * @param bool                 $caseSensitive    emit `caseSensitive: true` on the search filter (case-sensitive
+     *                                               strategy); the new search filters are case-insensitive by default
+     * @param array<string, mixed> $arguments        constructor arguments to pass to the (kept) filter, named
      */
     public function __construct(
         public string $key,

src/Symfony/Bundle/Command/Upgrade/UpgradeApiFilterResolver.php

@@ -52,15 +52,15 @@ public function __construct(
 
     /**
      * @param list<array{filter: FilterInterface, filterClass: class-string, arguments: array<string, mixed>}> $filters
-     *                                                                                                          one entry per `#[ApiFilter]` declaration (keyed by service id upstream so that two
-     *                                                                                                          instances of the same filter class are kept distinct)
+     *                                                                                                                          one entry per `#[ApiFilter]` declaration (keyed by service id upstream so that two
+     *                                                                                                                          instances of the same filter class are kept distinct)
      * @param list<FilterInterface>                                                                            $reservedFilters in-place service filters (the resource `filters:` array) whose query keys must
-     *                                                                                                          not be re-migrated: an #[ApiFilter] mapping onto one of these keys would shadow it
-     *
-     * @return list<UpgradeApiFilterParameter>
+     *                                                                                                                          not be re-migrated: an #[ApiFilter] mapping onto one of these keys would shadow it
      *
      * @throws UpgradeApiFilterCollisionException when two filters map to the same parameter key, or an
      *                                            #[ApiFilter] key collides with an in-place service filter
+     *
+     * @return list<UpgradeApiFilterParameter>
      */
     public function resolve(string $resourceClass, array $filters, array $reservedFilters = []): array
     {
@@ -81,7 +81,7 @@ public function resolve(string $resourceClass, array $filters, array $reservedFi
 
             // The mode of a DateFilter (include/exclude null) lives in the constructor `properties` map
             // as the value, never in getDescription(); read it straight from the filter instance.
-            $rawProperties = is_callable([$filter, 'getProperties']) ? ($filter->getProperties() ?? []) : [];
+            $rawProperties = \is_callable([$filter, 'getProperties']) ? ($filter->getProperties() ?? []) : [];
 
             foreach ($this->group($description) as $key => $info) {
                 if (isset($seenKeys[$key])) {
@@ -167,7 +167,7 @@ private function group(array $description): array
      */
     private function assertNoNameConversion(FilterInterface $filter, array $description): void
     {
-        $nameConverter = is_callable([$filter, 'getNameConverter']) ? $filter->getNameConverter() : null;
+        $nameConverter = \is_callable([$filter, 'getNameConverter']) ? $filter->getNameConverter() : null;
         if (!$nameConverter instanceof NameConverterInterface) {
             return;
         }

src/Symfony/Bundle/Command/Upgrade/UpgradeApiFilterVisitor.php

@@ -42,7 +42,7 @@ final class UpgradeApiFilterVisitor extends NodeVisitorAbstract
     private array $removedFilterShortNames = [];
 
     /**
-     * @param string                       $className  FQCN of the resource class to transform
+     * @param string                          $className  FQCN of the resource class to transform
      * @param list<UpgradeApiFilterParameter> $parameters resolved QueryParameter targets to inject
      */
     public function __construct(
@@ -83,8 +83,11 @@ private function removeApiFilterAttributes(Node\Stmt\Class_ $node): void
             $this->stripApiFilter($property);
         }
 
-        foreach ($node->getMethod('__construct')?->params ?? [] as $param) {
-            $this->stripApiFilter($param);
+        $constructor = $node->getMethod('__construct');
+        if (null !== $constructor) {
+            foreach ($constructor->params as $param) {
+                $this->stripApiFilter($param);
+            }
         }
     }
 

src/Symfony/Bundle/Command/UpgradeApiFilterCommand.php

@@ -194,7 +194,7 @@ private function reservedFilters(string $resourceClass): array
     }
 
     /**
-     * @param list<\ApiPlatform\Symfony\Bundle\Command\Upgrade\UpgradeApiFilterParameter> $parameters
+     * @param list<Upgrade\UpgradeApiFilterParameter> $parameters
      */
     private function transform(string $code, string $resourceClass, array $parameters): string
     {

src/Symfony/Tests/Bundle/Command/UpgradeApiFilterResolverTest.php

@@ -37,8 +37,8 @@
 final class UpgradeApiFilterResolverTest extends TestCase
 {
     /**
-     * @param array<string, Type> $nativeTypes   property name => native type used to detect relations
-     * @param list<string>         $resourceClasses class names the resolver should treat as API resources
+     * @param array<string, Type> $nativeTypes     property name => native type used to detect relations
+     * @param list<string>        $resourceClasses class names the resolver should treat as API resources
      */
     private function resolver(array $nativeTypes = [], array $resourceClasses = []): UpgradeApiFilterResolver
     {