fix(jsonld): genId false should work with embeded resources#7219
Merged
Conversation
soyuka
force-pushed
the
fix/genid-resource-embed
branch
4 times, most recently
from
June 19, 2025 09:56
40fcfac to
8641e9e
Compare
soyuka
force-pushed
the
fix/genid-resource-embed
branch
from
June 19, 2025 10:07
8641e9e to
d760ce2
Compare
This was referenced Jun 30, 2025
NoResponseMate
added a commit
to Sylius/Sylius
that referenced
this pull request
Jun 30, 2025
…atform changes with usage of genId (#18196) | Q | A |-----------------|----- | Branch? | 2.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT This PR fixes issue with APIP 4.1.17: https://github.com/Sylius/Sylius/actions/runs/15963124014/job/45018806151#step:11:16, after api-platform/core#7219. Reference: api-platform/core#7261 <!-- - Bug fixes must be submitted against the 1.14 or 2.0 branch - Features and deprecations must be submitted against the 2.1 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Updated the Taxon API resource configuration to explicitly set the URL generation strategy, which affects how URLs are generated for Taxon-related API operations. * **Style** * Minor formatting adjustment in the XML property tag for channel price history configuration (no impact on functionality). <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class is a resource
genIdhad no impact. Thanks to this patch you can usegenIdfalse to get the embeded result even if the resource is declared.Example:
Outputs:
{ "@context": "/contexts/GenIdFalse", "@id": "/gen_id_falsy", "@type": "GenIdFalse", "id": "1", "aggregateRating": { "@type": "AggregateRating", "ratingValue": 2, "ratingCount": 3 } }TODO: Ignore on attribute still shows in JSON-LD context (edit could not reproduce it works)