fix: ApiPlatform\Symfony\Bundle\Test\Client::getContainer return type - #7230
Merged
Conversation
ApiPlatform\Symfony\Bundle\Test\Client::getContainer return typeApiPlatform\Symfony\Bundle\Test\Client::getContainer return type
VincentLanglet
force-pushed
the
fixGetContainer
branch
from
June 18, 2025 15:42
a75d5b7 to
aacbabe
Compare
VincentLanglet
force-pushed
the
fixGetContainer
branch
from
June 18, 2025 15:45
aacbabe to
c35546d
Compare
Member
|
I like the change but its a bc break to change a return type https://symfony.com/doc/current/contributing/code/bc.html#changing-classes. Would you be able to target the main branch? |
Contributor
Author
I don't think it is since the class is final, no ? |
Member
|
thanks @VincentLanglet ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation was
but
this->kernelBrowseris not nullable and KernelBrowser implementation isso it's never nullable.