fix(cors): lowercase cors headers for rack 3 compatibility#42
Merged
Conversation
Modify CORS headers to use lowercase keys for Rack 3.x compatibility. In non-production environments Rack 3 throws lint errors instead of rendering pages if any of the headers are capitalized. This is to conform with the HTTP/2 specification.
38e9606 to
7b5388f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR modifies CORS header keys to use lowercase format for Rack 3.x compatibility, conforming to the HTTP/2 specification which requires lowercase header names.
Key Changes:
- Updated CORS header keys from PascalCase to lowercase in the core CORS module
- Updated all test assertions to expect lowercase CORS header keys
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/apia/cors.rb | Updated CORS header keys from PascalCase (e.g., 'Access-Control-Allow-Origin') to lowercase (e.g., 'access-control-allow-origin') |
| spec/specs/apia/cors_spec.rb | Updated test expectations and descriptions to use lowercase CORS header keys |
| spec/specs/apia/endpoint_spec.rb | Updated test assertions to expect lowercase CORS header keys in response headers |
| spec/specs/apia/rack_spec.rb | Updated test assertions to expect lowercase CORS header keys in Rack response headers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adamcooke
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify CORS headers to use lowercase keys for Rack 3.x compatibility.
In non-production environments Rack 3 throws lint errors instead of
rendering pages if any of the headers are capitalized. This is to
conform with the HTTP/2 specification.