refactor: guard dev server DELETE handler and fix port parsing#1001
Merged
Conversation
Small fixes and cleanup to the dev/standby test server (src/dev_server.ts): - wrap DELETE handleRequest in try/catch (like POST/GET) so a rejection no longer crashes the process - PORT falls back to 3001 for empty or non-numeric values - log under the errMessage key in the URL-parse softFail - remove dead duplicate _meta.mcpSessionId injection - inline single-value TransportType/Routes enums Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jirispilka
commented
Jun 16, 2026
Comment on lines
-129
to
-133
| // Inject session ID into request params for existing sessions | ||
| if (req.body?.params) { | ||
| req.body.params._meta ??= {}; | ||
| req.body.params._meta.mcpSessionId = sessionId; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This was duplicated, the session is inject below
jirispilka
commented
Jun 16, 2026
Comment on lines
-26
to
-33
| enum TransportType { | ||
| HTTP = 'HTTP', | ||
| } | ||
|
|
||
| enum Routes { | ||
| MCP = '/', | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This was really not worth keeping
jirispilka
changed the title
MQ37
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes + cleanup to the dev/standby test server (
src/dev_server.ts); does not affect the hosted server.PORTfalls back to 3001 for empty/non-numeric valueserrMessagekey; dead duplicate session-id injection removed; single-value enums inlined🤖 Generated with Claude Code