test: run the browser crawler tests serially#3859
Merged
Merged
Conversation
`browser_crawler.test.ts` was the only test file using `test.concurrent`, and the only one giving different results run to run - locally it failed anywhere between 3 and 10 tests, with the set changing each time, which makes it useless for telling whether a change actually broke something. Running serially costs ~28s for the file and makes the outcome deterministic.
B4nan
added
adhoc
barjin
pushed a commit
that referenced
this pull request
Jul 20, 2026
`browser_crawler.test.ts` is the only test file in the repo using `test.concurrent`, and the only one that gives different results run to run. Locally it failed anywhere between 3 and 10 tests with the set changing every time, which makes it useless for telling whether a change actually broke something — I hit this while trying to work out whether a timeout change had regressed anything, and had to run a control on a clean branch to be sure it hadn't. Running the file serially costs ~28s and makes the outcome deterministic. Worth knowing: locally this does not make the file green — 9 tests fail consistently, identically on a clean v4, because they pass in isolation but not in file order. That pollution is pre-existing and out of scope here; this only removes the variance that was hiding it. If CI is green, those 9 are local-environment-specific and can be looked at separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browser_crawler.test.tsis the only test file in the repo usingtest.concurrent, and the only one that gives different results run to run. Locally it failed anywhere between 3 and 10 tests with the set changing every time, which makes it useless for telling whether a change actually broke something — I hit this while trying to work out whether a timeout change had regressed anything, and had to run a control on a clean branch to be sure it hadn't.Running the file serially costs ~28s and makes the outcome deterministic.
Worth knowing: locally this does not make the file green — 9 tests fail consistently, identically on a clean v4, because they pass in isolation but not in file order. That pollution is pre-existing and out of scope here; this only removes the variance that was hiding it. If CI is green, those 9 are local-environment-specific and can be looked at separately.