-
Notifications
You must be signed in to change notification settings - Fork 120
0.10.0 #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fbartho
wants to merge
8
commits into
master
Choose a base branch
from
fb/0.10.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
0.10.0 #331
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
49e9cfe
chore: fix missing minimatch types
41e5ff0
chore: bump apollo v4
ac862e5
chore: bump ts v4
0677c32
chore: quickly fix everything until tests pass
06d6247
chore: quickly fix build
dfd7238
Upgrade most of our dependencies & get tests passing
fbartho 67aac0c
0.10.0-rc.1
fbartho 5445839
PR Feedback
fbartho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 16 | ||
| 24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| nodeLinker: node-modules |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,36 @@ | ||
| module.exports = { | ||
| export default { | ||
| roots: ['<rootDir>/src'], | ||
| globals: { | ||
| 'ts-jest': { | ||
| babelConfig: false, | ||
| mapCoverage: true, | ||
| compilerOptions: { | ||
| allowJs: true, // Necessary for jest.js | ||
| }, | ||
| diagnostics: { | ||
| ignoreCodes: [ | ||
| 151001 // Suppress esModuleInterop suggestion that breaks __tests__/restLink.ts | ||
| ] | ||
| } | ||
| }, | ||
| }, | ||
| preset: 'ts-jest/presets/default-esm', | ||
| extensionsToTreatAsEsm: ['.ts', '.tsx'], | ||
| transform: { | ||
| '.(ts|tsx)': 'ts-jest', | ||
| '^.+\\.tsx?$': [ | ||
| 'ts-jest', | ||
| { | ||
| useESM: true, | ||
| tsconfig: { | ||
| allowJs: true, | ||
| esModuleInterop: true, | ||
| }, | ||
| diagnostics: { | ||
| ignoreCodes: [ | ||
| 151001, // Suppress esModuleInterop suggestion that breaks __tests__/restLink.ts | ||
| ], | ||
| }, | ||
| }, | ||
| ], | ||
| '^.+\\.jsx?$': [ | ||
| 'ts-jest', | ||
| { | ||
| useESM: true, | ||
| }, | ||
| ], | ||
| }, | ||
| transformIgnorePatterns: ['node_modules/(?!(change-case|@fetch-mock)/)'], | ||
| testRegex: '(/__tests__/.*|\\.(test|spec))\\.(ts|tsx|js)$', | ||
| moduleFileExtensions: ['ts', 'tsx', 'js', 'json'], | ||
| setupFiles: ['./scripts/jest.js'], | ||
| setupFiles: ['./scripts/jest-setup.cjs'], | ||
| testEnvironment: 'jsdom', | ||
| moduleNameMapper: { | ||
| '^(\\.{1,2}/.*)\\.js$': '$1', | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // Setup fetch for JSDOM environment using CommonJS | ||
| // This runs before test files are loaded | ||
|
|
||
| // Polyfill ReadableStream for JSDOM (required by fetch-mock v12) | ||
| if (typeof global.ReadableStream === 'undefined') { | ||
| const streams = require('web-streams-polyfill'); | ||
| global.ReadableStream = streams.ReadableStream; | ||
| global.WritableStream = streams.WritableStream; | ||
| global.TransformStream = streams.TransformStream; | ||
| } | ||
|
|
||
| // Provide a basic fetch for initialization | ||
| require('isomorphic-fetch'); | ||
|
|
||
| // Create a placeholder that will be replaced by fetchMock | ||
| // Store original for tests that might need it | ||
| const originalFetch = global.fetch; | ||
|
|
||
| // Create a mutable reference that fetchMock can update | ||
| let currentFetch = originalFetch; | ||
|
|
||
| // Replace global.fetch with a function that calls whatever currentFetch points to | ||
| // This allows fetchMock to update the reference and have all code see the change | ||
| global.fetch = function(...args) { | ||
| return currentFetch.apply(this, args); | ||
| }; | ||
|
|
||
| // Make the currentFetch reference available so fetchMock setup can update it | ||
| global.__setMockFetch = function(fn) { | ||
| currentFetch = fn; | ||
| }; | ||
|
|
||
| // Also set up globalThis | ||
| globalThis.fetch = global.fetch; | ||
| globalThis.__setMockFetch = global.__setMockFetch; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // Polyfill fetch for JSDOM environment first | ||
| import 'isomorphic-fetch'; | ||
|
|
||
| // Import and set up fetch-mock globally for all tests | ||
| import fetchMock from '@fetch-mock/jest'; | ||
|
|
||
| // Patch global fetch for all tests | ||
| fetchMock.mockGlobal(); |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I may, I would suggest adding support for the
exportsfield in this release if you can as some bundlers treat the presence of that property as a breaking change. We waited to introduce it until 4.0 for this reason. Since v4 supports it, it should be safe to addexportsas well in this package 🙂.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert at CJS/ESM nonsense 😉, what should my exports config look like?
These are the files in our built directory: