Add support for a human-readable string whenever passing a maxAge via schema hint or dynamic hints in code#7911
Conversation
… schema hint or dynamic hints in code
👷 Deploy request for apollo-server-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…behaviour, added test coverage for plugin code
|
On an abstract level, we originally envisioned In practice I don't know if these abstract arguments about a subsystem that has not been incredibly actively developed recently should be considered to be more important than more pragmatic approaches, though. (We chose to have max age mean seconds without a particular unit in the title to match the HTTP |
|
@glasser This PR is definitely not a hill I will die on. 😄 This is more of a "convenient DX" more than anything since all it really does is convert it to seconds, which could be done with a calculator anyways. 😅 Happy to close the PR if you are feeling this doesn't add enough value to outweigh the tradeoffs. 😄 |
Add support for a human-readable string whenever passing a maxAge via schema hint or dynamic hints in code.
Addresses #7555.