Skip to content

fix(apollo-tools): add undeclared peer dependency graphql#2049

Merged
trevor-scheer merged 4 commits into
apollographql:masterfrom
merceyz:apollo-tools-peerdep
Mar 29, 2022
Merged

fix(apollo-tools): add undeclared peer dependency graphql#2049
trevor-scheer merged 4 commits into
apollographql:masterfrom
merceyz:apollo-tools-peerdep

Conversation

@merceyz

@merceyz merceyz commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

@apollographql/apollo-tools is using graphql without declaring it as a dependency, this causes issues under strict dependency environments (Yarn PnP) and causes it to rely on hoisting to hopefully place it in a accessible location which is not guaranteed.

Fixes #1680

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla

Copy link
Copy Markdown

@merceyz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@brandonchinn178

Copy link
Copy Markdown

Any update on this?

@merceyz

merceyz commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

@brandonchinn178 Since this wasn't merged "fast enough" I added this to the compat table in yarnpkg/berry#1847 so Yarn applies this automatically, it was released in 2.3.0

@brandonchinn178

Copy link
Copy Markdown

oh I see. I misread the error; I'm having problems with apollo-upload-client, not this package. I'll write an issue in the other package. Thanks!

@trevor-scheer

Copy link
Copy Markdown
Contributor

Sorry this was never looked at! Going to merge and get this fix released.

@trevor-scheer trevor-scheer merged commit 9907758 into apollographql:master Mar 29, 2022
@merceyz merceyz deleted the apollo-tools-peerdep branch March 29, 2022 20:36
@merceyz

merceyz commented Mar 29, 2022

Copy link
Copy Markdown
Contributor Author

No worries, that's what we have the compat plugin for 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Yarn v2, missing dependencies

5 participants