allow titlefield to be set to false#5496
Open
stuartromanek wants to merge 1 commit into
Open
Conversation
BoDonkey
reviewed
Jun 29, 2026
BoDonkey
self-requested a review
June 29, 2026 15:28
Contributor
|
Does the numbered index get automatically added to the UI? |
boutell
requested changes
Jun 29, 2026
boutell
left a comment
boutell
left a comment
Member
There was a problem hiding this comment.
I'd classify it as "minor" but no problem with adding the feature. Needs to make it to documentation as well
myovchev
reviewed
Jun 30, 2026
| ? null | ||
| : (this.field.titleField || 'title'); | ||
| const item = this.items.find(item => item._id === id); | ||
| return get(item.schemaInput.data, titleField) || `Item ${index + 1}`; |
Contributor
There was a problem hiding this comment.
Be sure that get(data, null) doesn't panic.
myovchev
approved these changes
Jun 30, 2026
myovchev
left a comment
myovchev
left a comment
Contributor
There was a problem hiding this comment.
A nice tiny feature. I agree it's a minor release (patch is a bug fix usually).
BoDonkey
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrays default back to using
titleas the defaulttitleFieldwith no way to opt out. Mytitlefield was an object and using it as a string was obviously breaking UI