i18n: add Korean (ko) translation#5519
Open
moduvoice wants to merge 1 commit into
Open
Conversation
Adds ko.json for the core @apostrophecms/i18n admin UI strings (packages/apostrophe/modules/@apostrophecms/i18n/i18n/ko.json, 776 keys, matching the en.json structure exactly) and for the ai-helper package (packages/ai-helper/i18n/aposAiHelper/ko.json, 19 keys). Both locales are auto-discovered by the i18n module's resource bundle loader, so no central registration was needed beyond adding the files. Includes a changeset per CONTRIBUTING.md/MONOREPO.md.
Contributor
|
Thank you for this submission. Can I ask how you came upon ApostropheCMS? We are always interested in branching out into new areas and hadn't run across any Korean sites using it, yet. |
Contributor
|
I should also say that I think I will have some issues reviewing this PR. I can, of course, verify the fidelity of the translation strings using an LLM. Where I will have an issue is in reviewing the display of the characters properly in the Admin UI. Have you verified and used the ApostropheCMS Admin UI with Hangul? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Korean (ko) translation PR body template
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.
Changes
packages/apostrophe/modules/@apostrophecms/i18n/i18n/ko.json— full Korean translation of the core admin UI (776 keys, matching the English source's key set and order exactly).packages/ai-helper/i18n/aposAiHelper/ko.json— full Korean translation of the AI Helper module (19 keys, matching the English source's key set and order exactly)..changeset/add-korean-i18n.md) covering both packages, following the same format as other merged changesets in this repo.<locale>.jsonfile placed in a module'si18n/directory (and ini18n/<namespace>/for namespaced modules) and registers it with i18next by filename, exactly like the existingde,es,fr,it,pt-BR, andsklocales.Testing
ko.jsonfiles have 0 missing / 0 extra keys vs. theiren.jsoncounterparts, and key order matches exactly.{{ variable }}interpolation placeholders and embedded HTML tags (e.g.<strong>) are preserved identically between English and Korean values for every key (0 mismatches)._pluralsuffix keys are correctly retained (i18next requires the key structure even though Korean has no grammatical plural); where the English singular hardcodes "one" instead of{{ count }}, the Korean singular correctly hardcodes "1" to match, and where English singular/plural both use{{ count }}, the Korean values are identical for both, as expected.dayjs*Formatkeys that other locales customize (dayjsTitleDateFormat,dayjsMediaCreatedDateFormat) use valid Korean date conventions (e.g.YYYY.MM.DD), while the two sentinel keys (dayjsCellDateFormat,dayjsRelativeTimeFormat) are correctly left as"apostrophe"(a special sentinel value read by the admin UI to trigger its own built-in fallback formatting), matching the convention already used by every other shipped locale.