Conversation
- Introduced '@apostrophecms/layout' widget in home and default page areas. - Updated layout styles to allow for a wider main content area. - Improved HTML structure for better layout management.
BoDonkey
left a comment
BoDonkey
left a comment
There was a problem hiding this comment.
I don't quite get the second area on the default page. Why break video out to a standalone area?
boutell
left a comment
boutell
left a comment
There was a problem hiding this comment.
I know this is only a draft and I am reviewing prematurely so this is a comment, not a blocker.
I think you should use 12 steps, and also explicitly configure the column widget's allowed contents even if it's the same as the default, so that it is easier for developers to understand how to add widgets to it. Otherwise layout feels like a black box and people reading Bob's documentation site won't really know what to do to add their very first custom widget.
| options: { | ||
| widgets: { | ||
| '@apostrophecms/layout': { | ||
| columns: 6, |
There was a problem hiding this comment.
Not appropriate here, it's tested and feels right in the context of the space it has.
There was a problem hiding this comment.
The Default page has 12. This also showcases the option override.
| @@ -0,0 +1,18 @@ | |||
| // Modify the layout column widget to allow the desired content types | |||
| // in the Layout widget. | |||
| export default { | |||
There was a problem hiding this comment.
@boutell Explicit define so that it's clear how to modify.
@BoDonkey It's a visual thing in the diff view. The widget list is |
There was a problem hiding this comment.
This allows only one level of layouts. Please demo nested layouts in a way that doesn't allow infinite nesting, and does restrict steps in a nested layout. (This means a subclass is needed.)
See the nested-layout branch for a working example although not in the lineage of this PR.
3 participants
DO NOT MERGE UNTIL AFTER RELEASE