Open
Conversation
- display label now shows Int characters properly instead of doubles with trailing zeros (i.e 1 instead of 1.0) - adjusted the AC button to do the same and displaying “0” int instead of “0.0” when clearing screen - adjusted the decimal/period button to start with 0. instead of displaying “.” as the first character when no number was entered - prevented the addition of multiple decimal in a number which leads to crashing the app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there Angela, I came here from your iOS development course, thanks for your great work.
I noticed that the app could crash in multiple cases and have a few bugs so here are the things I changed.