Skip to content

feat: Cleanup deprecated/unused entities and add method overloads - #878

Merged
mykola-mokhnach merged 1 commit into
masterfrom
revert-877-revert-876-rm-arg
May 21, 2026
Merged

feat: Cleanup deprecated/unused entities and add method overloads#878
mykola-mokhnach merged 1 commit into
masterfrom
revert-877-revert-876-rm-arg

Conversation

@mykola-mokhnach

Copy link
Copy Markdown
Contributor

Summary

  • Remove unused pkg argument from checkApkCert
  • Remove deprecated getAdbServerPort (use adb.adbPort instead)
  • Replace conditional generic return types on adbExec and shell with overloads keyed on outputFormat: 'full'
  • Add overloads on getConnectedDevices and getConnectedEmulators keyed on verbose: trueVerboseDevice[]
  • Type EXEC_OUTPUT_FORMAT on ADB so literal 'full' resolves correctly at call sites
  • Remove unused TFullOutputOption type
BREAKING CHANGE: `checkApkCert(appPath, pkg, opts?)` is now `checkApkCert(appPath, opts?)`. The `pkg` argument was never used.

BREAKING CHANGE: Deprecated `getAdbServerPort()` has been removed. Use `adb.adbPort` instead.

BREAKING CHANGE: `TFullOutputOption` type has been removed

Migration

Before After
adb.checkApkCert(appPath, pkg) adb.checkApkCert(appPath)
adb.checkApkCert(appPath, pkg, opts) adb.checkApkCert(appPath, opts)
adb.getAdbServerPort() adb.adbPort

Type improvements (non-breaking)

  • adbExec(cmd, {outputFormat: 'full'})Promise<ExecResult>
  • shell(cmd, {outputFormat: 'full'})Promise<ExecResult>
  • getConnectedDevices({verbose: true})Promise<VerboseDevice[]>
  • getConnectedEmulators({verbose: true})Promise<VerboseDevice[]>

@mykola-mokhnach
mykola-mokhnach merged commit 2e368de into master May 21, 2026
13 checks passed
@mykola-mokhnach
mykola-mokhnach deleted the revert-877-revert-876-rm-arg branch May 21, 2026 16:16
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 15.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant