chore(tools): unify tool text results and driver resolution helpers#263
Open
Mochxd wants to merge 2 commits intoappium:mainfrom
Open
chore(tools): unify tool text results and driver resolution helpers#263Mochxd wants to merge 2 commits intoappium:mainfrom
Mochxd wants to merge 2 commits intoappium:mainfrom
Conversation
Adds shared helpers (textToolResult, requireDriver, toolErrorMessage) and migrates a first set of tools for consistent isError handling. Types the addTool logging wrapper via FastMCP. Related: enhancement proposal for MCP tool error/response contract (issue link in PR).
Contributor
Author
|
related to #262 |
Member
|
other tool files still use getDriver + throw + manual ContentResult. Are you planning for more PRs to address the issue on other tools? |
Contributor
Author
|
@SrinivasanTarget it is just a poc 🤙 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds shared helpers (textToolResult, requireDriver, toolErrorMessage) and migrates a first set of tools for consistent isError handling. Types the addTool logging wrapper via FastMCP.
Related: enhancement proposal for MCP tool error/response contract (issue link in PR).