Rename misleading blockSizeInBytes parameter to capacityInBytes in EXT4Unpacker#789
Merged
Conversation
1 task
Contributor
|
@adityabagchi24 Thanks! We have a few compatibility-breaking changes on the API in coming days so I'll plan to merge this alongside those. |
Contributor
Author
|
Sure, Thanks |
Contributor
Author
|
@jglogan I have noticed that the Linux compile check failed. Please let me know if there is something I can do from my end. |
jglogan
approved these changes
Jul 18, 2026
Contributor
|
@adityabagchi24 Merged, thank you! |
Contributor
Author
|
@jglogan Thank you so much for your cooperation and patience throughout the process of merging my PR. I truly appreciate your support. Please feel free to reach out if there's ever anything I can assist you with in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
The
blockSizeInBytesparameter onEXT4Unpackerwas misleading — it does not represent an ext4 filesystem block size.This change renames
blockSizeInBytestocapacityInBytes, updates the doc comment to accurately describe the parameter and updates the name in the call sites.Closes #787.