Avoid strong reference reader count overflow#131
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_startLoadingto reload and retry instead of publishing a wrapped count.Why
The strong-reference storage reserves a small reader-count field inside
DoubleWordand previously incremented it with wrapping arithmetic. If enough readers entered concurrently, the count could wrap and make the storage appear to have fewer active readers than it actually did.Testing
swift buildpasses locally.swift test --filter StrongReferenceRace.testReaderCountDoesNotWrapAtCapacitycould not run locally because this Swift toolchain cannot importXCTest.