System: remove unnecessary type casting#308
Merged
Merged
Conversation
Contributor
|
@swift-ci please test |
Collaborator
Author
|
@milseman is 6.3 the floor? if so, we will need to limit this until the floor is lifted, and only make the incorrect truncations explicit. |
Collaborator
Author
|
@swift-ci please test |
compnerd
force-pushed
the
typecast
branch
3 times, most recently
from
0f05243 to
7d24d78
Compare
The compiler now imports these as their canonical type, allowing us to directly use without the explicit type cast. Due to the floor of Swift 6.3, we must preserve the type cast values. Introduce an overlay to explicitly cast the values in the older compilers.
Collaborator
Author
|
@swift-ci please test |
glessard
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler now imports these as their canonical type, allowing us to directly use without the explicit type cast.