Install missing CSystem headers with CMake#323
Merged
glessard merged 1 commit intoJun 13, 2026
Conversation
fallintoplace
requested review from
glessard,
lorentey and
milseman
as code owners
Contributor
|
@swift-ci please test |
Contributor
|
@fallintoplace could you rebase your change onto the release/1.7.0 branch and target that branch for the pull request? |
fallintoplace
force-pushed
the
fix/csystem-install-headers
branch
from
e3ddf99 to
8b86871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the CSystem CMake install list to include the headers that installed consumers need:
CSystemWASI.h, which is referenced bymodule.modulemapio_uring.h, which is included byCSystemLinux.hWhy
The previous install list copied the module map and several platform headers, but left out two headers required by that installed module. That can break consumers that import
CSystemfrom a CMake-installed package outside the source tree.Validation
cmake -S . -B .build/cmake-install-check-ninja -G Ninja -DCMAKE_INSTALL_PREFIX=.build/install-check-ninjacmake --build .build/cmake-install-check-ninjacmake --install .build/cmake-install-check-ninjaprintf '@import CSystem;\nint main(void) { return 0; }\n' | clang -fmodules -I .build/install-check-ninja/include/CSystem -x objective-c -c -o /dev/null -