Add missing System sources to CMake build#325
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
jrflat
reviewed
Jun 15, 2026
jrflat
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! I verified locally on macOS/Linux, but I'll also trigger cross-repo CI that exercises the CMake path to confirm before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the CMake source list for SystemPackage so it matches the Swift sources in the SwiftPM target.
The CMake build now includes the previously omitted source groups:
It also enables the Swift Lifetimes feature for the CMake target, matching SwiftPM, so the Linux IORing sources are not compiled away when they are included.
Why
The CMake target had drifted from the SwiftPM target. CMake consumers could get a successful build while the produced module was missing newer API areas.
Validation