Skip to content

Forward io_uring_enter2 size argument#326

Merged
glessard merged 1 commit into
apple:release/1.7.0from
fallintoplace:fix/io-uring-enter2-size
Jun 26, 2026
Merged

Forward io_uring_enter2 size argument#326
glessard merged 1 commit into
apple:release/1.7.0from
fallintoplace:fix/io-uring-enter2-size

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

This updates the io_uring_enter2 shim to pass its size argument through to the io_uring_enter syscall.

Why

The wrapper accepted a size argument, but always passed the sigset size instead. Extended-argument callers compute the size they need, so the wrapper should not discard it.

The older io_uring_enter helper still passes the sigset size when it calls io_uring_enter2, which keeps that path unchanged.

Validation

  • cmake configure with Ninja and CMAKE_INSTALL_PREFIX=.build/install-io-uring-enter2-check
  • cmake --build .build/cmake-io-uring-enter2-check
  • cmake --install .build/cmake-io-uring-enter2-check
  • Confirmed the installed CSystem io_uring.h forwards the sz argument

@FranzBusch FranzBusch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me. @Catfish-Man mind taking a look as well?

@glessard

Copy link
Copy Markdown
Contributor

This is a needed fix, but we also need additional testing. I'll add that separately.

@glessard glessard merged commit 58bce12 into apple:release/1.7.0 Jun 26, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants