chore: adding ce files - #41136
Merged
Merged
Conversation
Contributor
WalkthroughThis change updates Cypress end-to-end tests and supporting utilities to align with new Git API endpoint contracts. It refactors all relevant network intercepts, feature flag logic, and related assertions to use the updated Changes
Sequence Diagram(s)sequenceDiagram
participant CypressTest
participant GitAPI
participant UI
CypressTest->>GitAPI: Intercept /api/v1/git/applications/* (various endpoints)
CypressTest->>UI: Perform UI actions (e.g., click, wait for elements)
GitAPI-->>CypressTest: API responses (autocommit, discard, disconnect, etc.)
CypressTest->>UI: Assert UI state / response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
Bot
added
Task
brayn003
requested review from
ashit-rath
and removed request for
ApekshaBhosale
July 28, 2025 09:37
ashit-rath
reviewed
Jul 28, 2025
ashit-rath
left a comment
ashit-rath
left a comment
Contributor
There was a problem hiding this comment.
Minor callouts but rest looks good
Comment on lines
-221
to
-228
| agHelper.AssertContains( | ||
| Cypress.env("MESSAGES").DISCARDING_AND_PULLING_CHANGES(), | ||
| ); | ||
| cy.contains(Cypress.env("MESSAGES").DISCARDING_AND_PULLING_CHANGES()); | ||
| agHelper.Sleep(2000); | ||
|
|
||
| agHelper.AssertElementVisibility(".ads-v2-callout__children"); | ||
| agHelper.AssertElementVisibility(gitSync.locators.opsDiscardBtn); |
Contributor
There was a problem hiding this comment.
Don't we need these checks?
Comment on lines
+363
to
+368
| // cy.get( | ||
| // `div${this.locators.branchItem} ${this.commonLocators._btnSpinner}`, | ||
| // { | ||
| // timeout: 500, | ||
| // }, | ||
| // ).should("exist"); |
Contributor
There was a problem hiding this comment.
Let's remove the comments?
ashit-rath
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Git Cy test cleanup
Doc https://www.notion.so/appsmith/Cypress-Git-Tests-Full-Migration-Plan-Technical-Migration-Document-21cfe271b0e2808e9bbfc52ff3f271d1?source=copy_link
Fixes #41116
Automation
/ok-to-test tags="@tag.Git"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/16609928353
Commit: c44fe06
Cypress dashboard.
Tags:
@tag.GitSpec:
Wed, 30 Jul 2025 00:46:28 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit