Skip to content

feat: support annotations on Deployment/StatefulSet in Helm chart - #41552

Merged
wyattwalter merged 2 commits into
releasefrom
claude/sharp-shirley
Feb 11, 2026
Merged

wyattwalter merged 2 commits into
releasefrom
claude/sharp-shirley

Conversation

@wyattwalter

@wyattwalter wyattwalter commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a new top-level annotations value in the Helm chart that gets applied to the Deployment/StatefulSet metadata
  • Also wires up the existing commonAnnotations value to the Deployment/StatefulSet, which was previously missing from this resource
  • Enables use cases like Stakater Reloader (reloader.stakater.com/auto: "true") and other annotations that need to live on the workload resource

Example usage

annotations:
  reloader.stakater.com/auto: "true"

Test plan

  • Deploy chart with annotations set and verify annotations appear on the StatefulSet metadata
  • Deploy chart with workload.kind: Deployment and verify annotations appear on the Deployment metadata
  • Deploy chart with commonAnnotations set and verify they also appear on the Deployment/StatefulSet
  • Deploy chart with both annotations and commonAnnotations to verify they merge correctly
  • Deploy chart with neither set and verify no annotations block is rendered

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added support for custom deployment annotations via a new annotations setting
    • Added support for custom pod-level annotations via a new podAnnotations setting
    • Annotations are now conditionally rendered and merged from common and resource-specific sources
  • Tests

    • Added tests covering annotation presence, merging, and propagation for Deployments and StatefulSets
  • Chores

    • Chart version bumped to 3.6.9

Warning

Tests have not run on the HEAD a877940 yet


Wed, 11 Feb 2026 20:46:53 UTC

Add a top-level `annotations` value that gets applied to the main
Appsmith Deployment or StatefulSet metadata. This enables use cases like
Stakater Reloader (`reloader.stakater.com/auto: "true"`) and other
annotations that must live on the workload resource itself rather than
on pods. Also wires up `commonAnnotations` to the workload resource,
which was previously missing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added the Enhancement New feature or request label Feb 11, 2026
@coderabbitai

coderabbitai Bot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Adds conditional annotations rendering to the Helm deployment template, introduces top-level annotations and podAnnotations keys in values.yaml, bumps the chart version, and adds Helm tests validating annotation presence and merging for Deployment and StatefulSet resources.

Changes

Cohort / File(s) Summary
Helm template
deploy/helm/templates/deployment.yaml
Introduces a conditional metadata.annotations block that renders .Values.annotations and .Values.commonAnnotations via tplvalues.render when provided.
Values & Chart
deploy/helm/values.yaml, deploy/helm/Chart.yaml
Adds top-level annotations and podAnnotations keys to values; bumps chart version from 3.6.8 to 3.6.9.
Tests
deploy/helm/tests/annotations_test.yaml
New Helm tests covering absence, single-source, and merged annotations across StatefulSet and Deployment manifests; assertions check kind and metadata.annotations subsets.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

A tiny key in YAML's seam,
Whispers metadata into the stream.
Charts inch forward, tests applaud,
Annotations hum — the cluster's awed. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding support for annotations on Deployment/StatefulSet resources in the Helm chart.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description adequately covers the feature summary, use cases, and includes a test plan with checkboxes, though some test items are unchecked.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/sharp-shirley

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tests cover: annotations on StatefulSet and Deployment, commonAnnotations
on the workload resource, merging both annotation sources, multiple
annotations, and no annotations when none are set. Bumps chart version
to 3.6.9.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@sebastianiv21 sebastianiv21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyattwalter
wyattwalter merged commit 2ac615e into release Feb 11, 2026
31 checks passed
@wyattwalter
wyattwalter deleted the claude/sharp-shirley branch February 11, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants