Conversation
Intercom widget loading is already gone; drop leftover INTERCOM env aliases that could still map an old Intercom app id into Pylon. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe change removes legacy Intercom environment variable fallbacks from Pylon configuration and updates the Playwright CI workflow to pass the Pylon app ID variable. ChangesPylon configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change removes obsolete Intercom environment fallbacks and aligns Playwright CI with the Pylon app ID without introducing a known user-facing or production risk. No actionable merge-blocking risk remains beyond normal checks. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
The Intercom chat widget (
widget.intercom.io) was already replaced by Pylon in #41722. This PR removes leftover Intercom environment variable fallbacks that could still treat an oldAPPSMITH_INTERCOM_APP_ID/REACT_APP_INTERCOM_APP_IDas a Pylon app id.Changes:
index.htmland client configsapp/client/.env.exampleAPPSMITH_PYLON_APP_ID(matching other CI workflows)Out of scope: renaming
IntercomConsent/isIntercomConsentGiven(those still gate Pylon consent UX/API).Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Communication
Should the DevRel and Marketing teams inform users about this change?
Test plan
APPSMITH_INTERCOM/REACT_APP_INTERCOM/DISABLE_INTERCOM/widget.intercomAPPSMITH_PYLON_APP_IDset, Pylon stub/boot still worksMade with Cursor
Summary by CodeRabbit