Skip to content

chore: remove legacy Intercom env fallbacks after Pylon migration #42151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomjose92 wants to merge 1 commit into from
Closed

chore: remove legacy Intercom env fallbacks after Pylon migration #42151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ jobs:
-v "$PWD/stacks:/appsmith-stacks" \
-e APPSMITH_LICENSE_KEY="$APPSMITH_LICENSE_KEY" \
-e APPSMITH_DISABLE_TELEMETRY=true \
-e APPSMITH_INTERCOM_APP_ID=DUMMY_VALUE \
-e APPSMITH_PYLON_APP_ID=DUMMY_VALUE \
-e APPSMITH_CLOUD_SERVICES_BASE_URL=http://host.docker.internal:5001 \
-e APPSMITH_CLOUD_SERVICES_SIGNATURE_BASE_URL=http://host.docker.internal:8090 \
-e APPSMITH_RATE_LIMIT=1000 \
Expand Down
3 changes: 0 additions & 3 deletions app/client/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,3 @@
# Pylon in-app chat — APP_ID from https://app.usepylon.com/settings/in-app-chat
# Docs: https://docs.usepylon.com/pylon-docs/chat-widget/chat-setup
REACT_APP_PYLON_APP_ID=

# Legacy: Intercom app id (only if you have not migrated env vars yet)
# REACT_APP_INTERCOM_APP_ID=
10 changes: 3 additions & 7 deletions app/client/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,9 @@

const PYLON_APP_ID_RAW =
parseConfig("%REACT_APP_PYLON_APP_ID%") ||
parseConfig("%REACT_APP_INTERCOM_APP_ID%") ||
parseConfig('{{env "APPSMITH_PYLON_APP_ID"}}') ||
parseConfig('{{env "APPSMITH_INTERCOM_APP_ID"}}');
const DISABLE_PYLON =
parseConfig('{{env "APPSMITH_DISABLE_PYLON"}}') ||
parseConfig('{{env "APPSMITH_DISABLE_INTERCOM"}}');
// No third-party chat widget on airgapped deployments (same as BetterBugs / legacy Intercom)
parseConfig('{{env "APPSMITH_PYLON_APP_ID"}}');
const DISABLE_PYLON = parseConfig('{{env "APPSMITH_DISABLE_PYLON"}}');
// No third-party chat widget on airgapped deployments (same as BetterBugs)
const PYLON_APP_ID =
AIRGAPPED || typeof PYLON_APP_ID_RAW !== "string"
? ""
Expand Down
5 changes: 1 addition & 4 deletions app/client/src/ce/configs/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,7 @@ export const getConfigsFromEnvVars = (): INJECTED_CONFIGS => {
releaseDate: "",
edition: process.env.REACT_APP_VERSION_EDITION || "",
},
pylonAppID:
process.env.REACT_APP_PYLON_APP_ID ||
process.env.REACT_APP_INTERCOM_APP_ID ||
"",
pylonAppID: process.env.REACT_APP_PYLON_APP_ID || "",
mailEnabled: process.env.REACT_APP_MAIL_ENABLED
? process.env.REACT_APP_MAIL_ENABLED.length > 0
: false,
Expand Down
Loading